Borrow and stake support pcape #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GopherJ
reviewed
Sep 3, 2023
| 0, | ||
| stakingInfo.cashAmount | ||
| ); | ||
| IPToken(PCAPE).burn( |
There was a problem hiding this comment.
shall we check if we need to turn off collateral?
There was a problem hiding this comment.
yeah. We should.
GopherJ
reviewed
Sep 3, 2023
| 0, | ||
| stakingInfo.cashAmount | ||
| ); | ||
| IPToken(PCAPE).burn( |
There was a problem hiding this comment.
since we already read cApeReserveCache, why not we just use xTokenAddress from that?
GopherJ
reviewed
Sep 3, 2023
helpers/contracts-deployments.ts
Outdated
| @@ -553,12 +553,21 @@ export const deployPoolApeStaking = async ( | |||
|
|
|||
| const config = getParaSpaceConfig(); | |||
| const treasuryAddress = config.Treasury; | |||
|
|
|||
| const cApe = await getAutoCompoundApe(); | |||
| let pcApeAddress = "0x5F56386F21766237707a447FB37C717dC221bb13"; //for test env | |||
There was a problem hiding this comment.
this breaks other deployment
billyz9611
reviewed
Sep 3, 2023
| DataTypes.ReserveCache memory cApeReserveCache = cApeReserve | ||
| .cache(); | ||
| address PCAPE = cApeReserveCache.xTokenAddress; | ||
| require( |
There was a problem hiding this comment.
suggest require user's pcApe balance >= cashAmount
billyz9611
reviewed
Sep 3, 2023
| stakingInfo.cashAsset == PCAPE, | ||
| Errors.INVALID_ASSET_TYPE | ||
| ); | ||
| cApeReserve.updateState(cApeReserveCache); |
There was a problem hiding this comment.
suggest check cAPE status is not Paused and is Active
GopherJ
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security Checklist
Make sure to think about each of these exploits in this PR.